Sam Clegg

Results 1781 comments of Sam Clegg

What are the build flags you are using then building the side module in clang-repl? They must be somehow different from those used in emscripten. I'm guessing you are missing...

> > What are the build flags you are using then building the side module in clang-repl? > > So these are the flags used for the side module (each...

The issue here (IIUC) is not how you build llvm, but how llvm is building the side module.

https://github.com/emscripten-core/emscripten/issues/23442#issuecomment-2671495343 > **I am not sure how but I see the 3rd parameter of createTargetMachine allows us to pass some features** https://github.com/llvm/llvm-project/blob/12f8ed58a039ff3a3365591203f76ae07a179215/llvm/include/llvm/MC/TargetRegistry.h#L456 > > So we currently pass nothing here....

I'm now able to manually trigger the update-website action from this PR branch so I think we can iterate here until its working.

I'm seeing: ``` remote: Permission to kripken/emscripten-site.git denied to github-actions[bot]. 247 fatal: unable to access 'https://github.com/kripken/emscripten-site/': The requested URL returned error: 403 ``` which I guess makes sense since we...

@dschuff any idea where the best place to start is? Should we add `emscripten-bot@` as a collaborator on the emscripten-site or do we need to issue some new token.

Turns out it was the `checkout` action that was fucking things up since it was overriding the auth method for the repo. Using `token: ${{ secrets.EMSCRIPTEN_BOT_TOKEN }}` during checkout fixed...

OK this seems to be working now. I think we should be good to land. PTAL

I think we should stop using this on the emscripten side so maybe we can just remove this flag?