Sam Clegg

Results 1782 comments of Sam Clegg

Is this a duplicate of https://github.com/emscripten-core/emscripten/issues/20296?

I think that is what #20296 is all about. The status quo is that `--embind-emit-tsd` specifically relates only toe embind stuff (i.e. stuff defined in `EMSCRIPTEN_BINDINGS`). Extending our typescript generation...

BTW, the JS library code such as embind_gen.js should already have full access to all settings as global variables. You can use the `{{{` `}}}` macro system to embed them...

I think the direction you are taking here looks good though! Would you be interesting in help work on this feature? I think @brendandahl has some thought about the way...

Marking as draft since I think this might be more complex that i thought. I'm think as long as we are buiding the main module as PIC the linker cannot...

I'll probably wait a couple more release before landing this.

> LGTM, but what's the goal here? Just to be on a more recent version as a matter of principle, or to get a better compiler, or something else? Just...

Any idea what that one test would be failing? Looks like its `test/spec/expected-output/func_ptrs.wast.log`.. and there is nothing being generated instead of `83 : i32`

> Please add tests 👍 I can add a test that confirm the that lock file is deleted. Added a test the races mentioned do not pose a problem is...

If we take that alternative approach I still think it would be nice to test against the actual release versions, rather than just the nearest emscripten release to the release...