lyne-components icon indicating copy to clipboard operation
lyne-components copied to clipboard

feat(sbb-checkbox, sbb-radio-button): split into regular and panel variants

Open MarioCastigliano opened this issue 10 months ago • 1 comments

Preflight Checklist

Issue

This PR Closes #2395

Pull request checklist

Please check if your PR fulfills the following requirements:

  • [x] Tests for the changes have been added (for bug fixes / features)
  • [x] Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

  • sbb-selection-panel renamed to sbb-selection-expansion-panel
  • sbb-checkbox split into sbb-checkbox and sbb-checkbox-panel
  • sbb-radio-button split into sbb-checkbox and sbb-radio-button-panel
  • sbb-checkbox-group and sbb-radio-button-group support the panel variants of their child components
  • selection-panel styling extracted into scss mixin

Browsers

I tested the build on the following browsers:

  • [ ] Firefox Desktop
  • [ ] Chrome Desktop
  • [ ] Edge Desktop
  • [ ] Safari Desktop
  • [ ] Chrome Mobile
  • [ ] Safari Mobile

Screen readers

I tested the build on the following browsers:

  • [ ] JAWS Firefox Desktop
  • [ ] JAWS Chrome Desktop
  • [ ] NVDA Firefox Desktop
  • [ ] NVDA Chrome Desktop
  • [ ] VoiceOver Safari Desktop
  • [ ] VoiceOver Chrome Desktop
  • [ ] VoiceOver Safari Mobile
  • [ ] Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Documentation content changes
  • [ ] Other (please describe):

Does this introduce a breaking change?

  • [x] Yes
  • [ ] No

Other information

MarioCastigliano avatar Apr 05 '24 07:04 MarioCastigliano