lyne-components icon indicating copy to clipboard operation
lyne-components copied to clipboard

feat(sbb-stepper): introduce `sbb-stepper` component

Open dauriamarco opened this issue 1 year ago • 2 comments

Preflight Checklist

Issue

This PR Closes #2380

Pull request checklist

Please check if your PR fulfills the following requirements:

  • [x] Tests for the changes have been added (for bug fixes / features)
  • [x] Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

  • introduces sbb-stepper, sbb-step-label and sbb-step components.

Browsers

I tested the build on the following browsers:

  • [x] Firefox Desktop
  • [x] Chrome Desktop
  • [x] Edge Desktop
  • [x] Safari Desktop
  • [x] Chrome Mobile
  • [x] Safari Mobile

Screen readers

I tested the build on the following browsers:

  • [x] JAWS Firefox Desktop
  • [x] JAWS Chrome Desktop
  • [x] NVDA Firefox Desktop
  • [x] NVDA Chrome Desktop
  • [x] VoiceOver Safari Desktop
  • [x] VoiceOver Chrome Desktop
  • [ ] VoiceOver Safari Mobile
  • [ ] Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Documentation content changes
  • [ ] Other (please describe):

Does this introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

dauriamarco avatar Mar 14 '24 09:03 dauriamarco

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.22%. Comparing base (e6397df) to head (59592be). Report is 21 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2491      +/-   ##
==========================================
+ Coverage   93.18%   93.22%   +0.03%     
==========================================
  Files         316      316              
  Lines       25389    25324      -65     
  Branches     2063     2065       +2     
==========================================
- Hits        23660    23609      -51     
+ Misses       1696     1682      -14     
  Partials       33       33              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 15 '24 06:03 codecov-commenter

Not really a review, just something missing which was in my mind: please add sbb-stepper to typography.scss where we have the lists of components to hide until defined ("// Hiding components until they are instantiated")

Sorry I was mixing it up. Wanted to write this for sbb-overlay ;) stepper should not be part of this list!

jeripeierSBB avatar Mar 18 '24 08:03 jeripeierSBB