Serge Barral

Results 29 comments of Serge Barral

No problem, I understand!

So as discussed in the other threads, you will need to safely update the waker in `AsyncSignal::poll`, and then you will need to coordinate this access with the sender. This...

Did you mean to close this one? This is orthogonal to issues #14 and #15 and is not fixed AFAICT.

Just to be clear because I don't know if this is what the misunderstanding is about: `UnsafeCell` does not allow concurrent mutable access, because that is always UB. What it...

Sorry I haven't fully internalized the operation of kanal yet, but why can't this call to `Waker::will_wake()`: https://github.com/fereidani/kanal/blob/e415d692ef628ca8dfea10dc0bdc53c7b898b28a/src/future.rs#L210-L211 be made concurrently with this call to `Waker::wake()` in `first.send()` here: https://github.com/fereidani/kanal/blob/e415d692ef628ca8dfea10dc0bdc53c7b898b28a/src/future.rs#L75-L77...

Oh yes, so that's what I wrote earlier: sometimes the waker is accessed concurrently with shared references (`clone()` and `will_wake()`), and sometimes mutably (exclusively). This would be correct if you...

For what it's worth, I hit today again what is most likely the same bug with a somewhat simpler example: ```rust let flag = Arc::new(AtomicBool::new(false)); let th = thread::spawn({ let...

While there is still time to revert this commit, I wanted to highlight a caveat which I initially missed so that the decision to proceed with this PR (or not)...

*Disclaimer: I haven't used `schemars` yet as I am waiting for version 1.0.0 to make `JsonScheme` a required trait in the public API of one of our libraries; in other...