aws-secrets-manager-actions icon indicating copy to clipboard operation
aws-secrets-manager-actions copied to clipboard

feat: github openid-connect aws actions support

Open Rishang opened this issue 2 years ago • 1 comments

Story

Why did you create this pull request?

Support for github openid connect actions, as it the best and secure was for use aws creds in github actions

Solves

check process.env for aws creds as session token

What dose this change?

logic to fetch aws creds

References

https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-amazon-web-services

Do you have any references? (eg. MDN, Stackoverflow)

Rishang avatar Feb 14 '22 04:02 Rishang

@Rishang Hello, thank you for your PR. Your code test looks failed. Please check this log. Thanks. https://github.com/say8425/aws-secrets-manager-actions/runs/5210475713?check_suite_focus=true#step:7:38

say8425 avatar Feb 16 '22 02:02 say8425

any word on this? Would be awesome if this could be merged

mrpatrick avatar Aug 29 '22 16:08 mrpatrick

  env:
    SECRET_NAME: 
    AWS_ACCESS_KEY_ID: 
    AWS_SECRET_ACCESS_KEY: 
    AWS_DEFAULT_REGION: 
    AWS_DEFAULT_OUTPUT: 

https://github.com/say8425/aws-secrets-manager-actions/actions/runs/3023204844/jobs/4863274552#step:7:4

Sorry to response, this PR origin from forked repository. So all secrets are empty, and it makes failed test. But pull_request_target trigger looks can access these environments. So I will change this trigger later.

Anyway this PR looks working. So I will fix conflict and approve it.

say8425 avatar Sep 14 '22 02:09 say8425

This PR was already merged.

say8425 avatar Sep 14 '22 03:09 say8425