Pranav Saxena
Pranav Saxena
@steveloughran @mehakmeet @mukund-thakur , requesting you to kindly review please. Thank you!
The spotbug warning is on the hadoop-common trunk code, and the warning is on the code-path which is not changed by this PR. ``` Bug type NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE (click for details)...
:::: AGGREGATED TEST RESULT :::: HNS-OAuth ======================== [INFO] Results: [INFO] [WARNING] Tests run: 137, Failures: 0, Errors: 0, Skipped: 2 [INFO] Results: [INFO] [ERROR] Failures: [ERROR] ITestAzureBlobFileSystemRandomRead.testSkipBounds:218->Assert.assertTrue:42->Assert.fail:89 There should not...
Hi @steveloughran, thank you very much for the suggestion. Have taken it. As part of the change, I have the following changes: 1. Added a new util class `AbfsInputStreamTestUtils` which...
Hi @steveloughran , thank you a lot for the review. Have taken the comments. Have taken assertj in the new test util class. Class `ITestAbfsInputStreamReadFooter` is now extending `AbstractAbfsScaleTest` so...
Thanks @steveloughran for the review. Have refactored the import order, and have refactored `log.error` to `log.debug`.
Thank you @steveloughran very much! Have opened a PR against branch-3.4 https://github.com/apache/hadoop/pull/6763. Thank you!
> > Lets add some tests around the change. > > @saxenapranav - Please see my thoughts on tests [here](https://github.com/apache/hadoop/pull/5953#issuecomment-1703097859). It is not clear to me how to add tests...