sekken
sekken copied to clipboard
savonrb
Nil nsid desperate fix
this tries to fix https://github.com/savonrb/sekken/issues/18
if I see the nsid is nil, I try to find the element in the xmlns namespace.
Coverage remained the same when pulling f504bc40a7036afcf7e5ff84a9d08aa3cca067ce on YACFirm:nil_nsid into 95375e84198568e870c4b6b71c17fe210cbff7cc on savonrb:master.
Coverage remained the same when pulling 7fdc7fe53aefb38fdc5880d185f2a912151b0b44 on YACFirm:nil_nsid into 95375e84198568e870c4b6b71c17fe210cbff7cc on savonrb:master.
Hey @dedsm I appreciate you submitting this pull request, but I'm hesitant to merge anything into Sekken without any tests for the functionality. Since Sekken is still fairly new, it would be helpful to have tests that express the desired behavior so that any refactoring that is done later can be done safely, knowing that there are tests for all of the existing features.
Is that something you'd be interested in doing?
sure, right now I'm on vacations but from next week I can start working on this, I didn't do it because I don't know if my case is a valid one because my experience with xml is near zero, so I hoped you guys to look into it and see if this is the best way of handling this.
El mar, 2 de diciembre de 2014 03:28, Tim Jarratt [email protected] escribió:
Hey @dedsm https://github.com/dedsm I appreciate you submitting this pull request, but I'm hesitant to merge anything into Sekken without any tests for the functionality. Since Sekken is still fairly new, it would be helpful to have tests that express the desired behavior so that any refactoring that is done later can be done safely, knowing that there are tests for all of the existing features.
Is that something you'd be interested in doing?
— Reply to this email directly or view it on GitHub https://github.com/savonrb/sekken/pull/19#issuecomment-65192508.
Thanks for the honesty :grinning:. Unfortunately, I've never seen this, and I doubt many other people have because Sekken is still relatively new. Most of the features in Savon and Sekken have come about because someone found that the gem did not work with their SOAP service, so they extended. That's one of the best parts of open source software in my opinion; you get a chance to improve it too! We might be experts at some parts of ruby and SOAP, but we don't know everything (in particular we have no idea how well Sekken works with your API).