savon icon indicating copy to clipboard operation
savon copied to clipboard

Use proper namespaces for message content

Open haider-cialfo opened this issue 5 years ago • 6 comments

Fixes #899 #820 #895 #862

haider-cialfo avatar Jun 27 '19 08:06 haider-cialfo

Can this be merged, please???

taschetto avatar Oct 23 '19 02:10 taschetto

Didn't notice this when I added my PR #917. That PR also has a breaking test. Would be very helpful for one of the two PRs to be merged.

lukaso avatar Dec 04 '19 13:12 lukaso

Given the slow pace of incorporating changes, I've created a gem that patches this issue. All you have to do is include it in your Gemfile:

gem 'savon_fixes'

You can find the gem here: https://github.com/lukaso/savon_fixes. It currently covers off these issues and PRs: #916, #899, #820, #895, #862, #905 and #549 (they are all duplicates).

I haven't yet tested it in anger, but all tests pass, so please feedback if there are any issues. Adaptations of PRs here are also welcome.

lukaso avatar May 25 '20 10:05 lukaso

@pcai @tjarratt @rubiii We do have the same issue, and we have been hacking things along. Is there anything we can do to speed things up? Any help we can provide?

Should there be any other governance model, given that the gem seems to be on palliative care?

This gem has a significant amount of downloads so it's a major security issue to onboard new people or change ownership. But there has to be something the community can do to help?...

Also, please consider disabling the stale bot.

sergioisidoro avatar Jun 02 '20 13:06 sergioisidoro

👋 Thanks for all the work on fixing things, it really helps. ❤️

In order to merge this, even if it is a thing that looks like it's fixing outstanding issues, the test suite has not been amended with new cases.

So, to help this change get merged, add some kind of test (that would fail without this change) to the suite.

olleolleolle avatar Jul 15 '22 05:07 olleolleolle

This is a duplicate of #917 which has been merged (with test). This should be closed.

lukaso avatar Jul 20 '22 14:07 lukaso

closing per prior comment

pcai avatar Sep 21 '22 20:09 pcai