savon icon indicating copy to clipboard operation
savon copied to clipboard

Fix namespace problem for array schema elements and respect XML schem…

Open warnickr opened this issue 8 years ago • 14 comments

…a sequence ordering

warnickr avatar Mar 23 '17 22:03 warnickr

Looks like I need to add an additional test to avoid the decrease in coverage.

warnickr avatar Mar 23 '17 23:03 warnickr

Reverted bad patch for array handling. The patch for XML schema ordering works well for my use.

warnickr avatar May 05 '17 18:05 warnickr

This affects our integration. Ruby Hash default key order ends up determining the XML of the request instead of the governing WSDL document's xs:sequence. See: #859

atz avatar Feb 07 '18 23:02 atz

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 09 '18 00:04 stale[bot]

This issue is now closed due to inactivity. If you believe this needs further action, please re-open to discuss.

stale[bot] avatar Apr 16 '18 00:04 stale[bot]

@warnickr thanks for your contribution, and apologies this went unreviewed so long. I think I understand this change. Would you be able to add some specs to cover this scenario?

pcai avatar May 10 '18 02:05 pcai

It may take me a few weeks to get to it, but I will merge in the latest and add some specs.

warnickr avatar May 11 '18 13:05 warnickr

Thank you for your persistence and your help.

pcai avatar May 11 '18 14:05 pcai

We've been bitten by this as well. I'm not that familiar with Gyoku etc. Is this PR still active?

hlascelles avatar Oct 29 '18 16:10 hlascelles

I'm not sure why this PR is not merged yet. Can we have some advances on this topic? I'm requiring this on a project.

gtoroap avatar Dec 28 '18 15:12 gtoroap

@warnickr do you need to share the burden? This seems like a vital update to a commonly used tool.

hlascelles avatar Jan 03 '19 18:01 hlascelles

This is still an issue for us. What do people think @pcai @olleolleolle?

hlascelles avatar Jul 15 '20 09:07 hlascelles

The current state is: the change needs specs.

Any effort to add specs is welcome, even only a description in words (a PR to the PR would be even easier to use).

olleolleolle avatar Jul 15 '20 10:07 olleolleolle