ocaml-ffmpeg icon indicating copy to clipboard operation
ocaml-ffmpeg copied to clipboard

Fix invalid c99 code on 0.4.1

Open luisogandob opened this issue 6 years ago • 3 comments

It's ready to publish on 0.4.2

luisogandob avatar Apr 13 '20 23:04 luisogandob

Thanks for this PR! It seems a little too light for a full release. Have you tried the opam pin mechanism? This should work, if you're in the binding's directory with these changes applied to 0.4.1:

opam install -y .

This will pin the current repository as your fixed version for ffmpeg and installed it with your changes.

toots avatar Apr 14 '20 05:04 toots

Hi - It"s a small PR but important. I did install using the opam pin add method but that add like 3 extra steps to install process (download code, fix, pin) and to get that conclusion it's take hours of research to users without previous experience -like me- because the first assumption is "i'm doing something wrong cause code of the example should work". As you are working on 0.5.0 i think this could be a revision 0.4.2 in the meantime. Thanks.

luisogandob avatar Apr 14 '20 12:04 luisogandob

Hi @luisogandob. I totally understand. I will keep an eye on this will consider publishing a release in the future if nothing else comes up.

toots avatar Apr 17 '20 02:04 toots