liquidsoap icon indicating copy to clipboard operation
liquidsoap copied to clipboard

Published 20 hours ago • verified publisher icon savonet

refactor(prometheus): Change prometheus port

Open vitoyucepi opened this issue 3 months ago • 2 comments

Summary

It's good practice to allocate a specific port for each individual Prometheus metrics exporter. This commit changes port 9090, which is used by the prometheus server itself, to 9599, which is used by an unavailable https://github.com/marco-m/pirograph exporter.

After merging this PR, the next step will be to change the wiki page https://github.com/prometheus/prometheus/wiki/Default-port-allocations.

Additional

#3772

vitoyucepi avatar Mar 12 '24 23:03 vitoyucepi

Thanks for this. I imagine that you're re-using an existing port because the list is limited?

toots avatar Mar 13 '24 14:03 toots

Yeah, the list is full, there are no free ports.

vitoyucepi avatar Mar 13 '24 15:03 vitoyucepi

How about port 9669?

vitoyucepi avatar Apr 02 '24 04:04 vitoyucepi

I defer to you on that, I have no preference :-)

toots avatar Apr 02 '24 13:04 toots

I'm fine with the current number and waiting for the merge. Just joking around, waiting for the Number-Man to arise.

vitoyucepi avatar Apr 03 '24 04:04 vitoyucepi

Is this ready for merge?

toots avatar May 06 '24 15:05 toots

Yes, this PR is ready to be merged.

vitoyucepi avatar May 06 '24 15:05 vitoyucepi

Merged thanks!

toots avatar May 06 '24 15:05 toots

https://github.com/prometheus/prometheus/wiki/Default-port-allocations/_compare/40243971e18622727d54b071e249565955511aaf

vitoyucepi avatar May 06 '24 15:05 vitoyucepi