liquidsoap
liquidsoap copied to clipboard
savonet
Format code and fix spelling errors
To be the one who will annoy on each commit, I propose to add a pre-commit config to format the code and check for spelling errors. This follows #1654.
There is also a CI job that enforce that.
The PR is quiet big, hope you don't mind.
This is awesome. Super down to integrate this. Having standardized format helps backport fixes over to rolling releases a lot.
Let us know when this is ready for in depth review!
Cool, I wasn't sure about the interest for this, so I didn't put too much effort.
One thing is bothering me, how could we handle this spelling error: https://github.com/savonet/liquidsoap/blob/ae732a784695fae92d7bac1d165b24b4e39c610f/src/core/io/alsa_io.ml#L92
I guess we have to send this upstream ? Or is this something we can change ?
One thing is bothering me, how could we handle this spelling error:
https://github.com/savonet/liquidsoap/blob/ae732a784695fae92d7bac1d165b24b4e39c610f/src/core/io/alsa_io.ml#L92
I guess we have to send this upstream ? Or is this something we can change ?
We are upstream for ocaml-alsa :)
However, this is not a typo: it should be read as "write int" (with int shortened to "n"), and this is the name already taken by the library
I think before marking this as ready for review, I would like to let the CI run to check everything is working as expected.
I think before marking this as ready for review, I would like to let the CI run to check everything is working as expected.
That's reasonable!
I think before marking this as ready for review, I would like to let the CI run to check everything is working as expected.
That's reasonable!
I was hoping that you could allow the pipeline to run, because I am a first contributor here, and it prevent any pipeline runs.
I think before marking this as ready for review, I would like to let the CI run to check everything is working as expected.
That's reasonable!
I was hoping that you could allow the pipeline to run, because I am a first contributor here, and it prevent any pipeline runs.
Launched.
Thanks @smimram. @jooola I think you need to resolve the conflicts before the actions can run.
I'll work on another branch on my repo so I don't bother you with the workflow approval thing.
I will fix the shell scripts in another PR, the main branch moves too fast to keep the branch up to date.