liquidsoap icon indicating copy to clipboard operation
liquidsoap copied to clipboard

Remove string interpolation

Open toots opened this issue 4 years ago • 5 comments

This is outdated and should be replaced by string getters everywhere it is still in use.

toots avatar Feb 07 '22 14:02 toots

Yes, nobody know about it / use it. Although, be careful, it's still in use in some scripts...

smimram avatar Feb 08 '22 08:02 smimram

See #2220.

smimram avatar Feb 10 '22 07:02 smimram

Note that output.file allows specifying the filename depending on current metadata, which is going to be difficult to reimplement with getters.

smimram avatar Feb 10 '22 07:02 smimram

I don't understand the motivation behind this ? being able to write a path as %Y-%m-%d/%Hh%M_%S.flac is more simpler and elegant than writing a complete function as in https://github.com/savonet/liquidsoap/discussions/2220#discussioncomment-2125860

martinkirch avatar Feb 26 '22 17:02 martinkirch

I think that Sam brings up a good point here and @martinkirch is right to follow-up with this. What we need to remove, I believe, is the generic string interpolation: s % hash type. We should definitely keep the functionalities around filename in output.file but make it specific to this operator.

toots avatar Mar 02 '22 17:03 toots

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 21 '22 05:09 stale[bot]

This feature is still too useful to remove. Closing!

toots avatar Sep 21 '22 15:09 toots