sous-chef
sous-chef copied to clipboard
savoirfairelinux
Better automate deploy
Changes proposed in this pull request:
- Automate the frontend compilation steps inside Dockerfile
- Make it so that
docker-compose upis enough to get the project running (admittedly with an empty database.) - Tidy up the subsidiary docker-compose files by coalescing their common bits directly into Dockerfile or the main docker-compose.yml
- Don't use docker-compose.override.yml, because explicit is better than implicit: instead name it docker-compose.dev.yml
- Add copious comments to the Dockerfile.
Status
This was branched off #757 so please merge that first.
- [ ] READY
- [x] HOLD
- [x] WIP (Work-In-Progress)
How to verify this change
Do a fresh checkout and a fresh build. See that it works with just docker-compose up. Try then with docker-compose -f docker-compose.yml -f docker-compose.yml up
Deployment notes and migration
- [ ] Migration is needed for this change
Additional notes
Deployment has been a huge headache for me. INSTALL.md is pretty nicely fleshed out, but it's still really hard to knowing when and what order to run things, and I would rather move as many instructions into (commented) scripts instead of into instructions that humans need to follow manually.
^ this was a change to the Docker stuff so per #758 the CI check is misleading here. The only way to verify this is to do a fresh build on your own machine.
Coverage decreased (-0.01%) to 95.338% when pulling f058291f1f15c0b8fdec4b7d2a223b5112cb546f on kousu:better-automate-deploy into 0dad0834637a2194c69143390c3a0d9990c6fda0 on savoirfairelinux:dev.
Ah, actually, this isn't quite working. It puts the static files in src/static/ instead of src/sous_chef/static
Coverage increased (+0.03%) to 95.378% when pulling b9e039d861158ea5c5e07912a3717785cf89cecc on kousu:better-automate-deploy into 0dad0834637a2194c69143390c3a0d9990c6fda0 on savoirfairelinux:dev.
Coverage remained the same at 95.352% when pulling 382852b99173f8500d65b9115a5a8d9fbffe5023 on kousu:better-automate-deploy into 0dad0834637a2194c69143390c3a0d9990c6fda0 on savoirfairelinux:dev.
Coverage increased (+0.01%) to 95.352% when pulling 166fced38bc957abc17dd3d7bcfce3fb084b0be4 on kousu:better-automate-deploy into a7c706878c1ea1ecee9164444686e8e811686c13 on savoirfairelinux:dev.
I'm probably not going to get to fixing this up this week. It shouldn't be tricky, but it just needs some repetition until it reliably puts all the files in the right paths, and docker rebuilds are really really slow and discouraging. So, this will happen, but you'll have to be patient with me. Thanks.
I think we need to reconcile this PR with #775, as both are working on the same files.
