Andrew Dupont
Andrew Dupont
I was all ready to say that this issue was happening for me as well, but it turned out that ⌘⌥⌃← and ⌘⌥⌃→ were already claimed by _different_ shortcuts in...
What if you attached everything to the `ui:dialog:before:close` event instead? (There isn't a `success` property on the event, but there probably should be anyway.)
That's fair. I'll add a `closeOnReturn` option.
> Else, how will we do something like > > ```scheme > [ > (attribute_value) > (quoted_attribute_value) > ] @string > ``` > > For zed's syntax highlighting? I might...
Also: if the new grammar is landed, it’ll obviate the change I made in PR #62.
Yeah, I've used injection selectors in the past. Based on my recollection, their main weakness is that they can only inject themselves into scopes that have been defined with `begin`...
I take it back! That was way easier than I expected. Prepending `L:` to the injection selector is the trick I was not aware of. I'll definitely update this PR...
Question, @patrickrgaffney: are you envisioning that the JSX grammar be something that people opt into, or something that just works? It seems like the best approach for an injected grammar...
I should point out that if you skip step 4 of the repro instructions, both “Check Backup” and “View Diff” behave as expected, because `getDiffData` doesn't report that the setting...