Andrew Dupont
Andrew Dupont
> It's not only the chained props highlighting, but also called functions (in top of the screenshot) and object key-value pairs (e.g. `{deep: true}` in the screenshot) and several other...
I notice that `Object` is colored… interestingly in your second screenshot. Legacy Tree-sitter scopes the `Foo` in `Foo.bar` as `support.type` — `support` makes sense, but `type` does not. It scopes...
@jeffplays2005, [those](https://github.com/pulsar-edit/pulsar/pull/968/commits/cc42807574c5f35340f61b307bc67ea925234b97) were [both](https://github.com/pulsar-edit/pulsar/pull/968/commits/93ed91716b15cbbf2606a02d85d0f9be25c3de0e) very easy to address. They're part of #968 and will ship in 1.116 — probably in about 11 days. Thanks!
I think we'll probably keep this issue open because, at very least, the logging should be more helpful here. Hopefully the stack trace is enough for us to piece together...
~~@Tamaranch has identified some changes in syntax highlighting colors in the new grammar in #872. I'll be assessing these to see which ones were inadvertent and will report back to...
Using [this file](https://gitlab.xfce.org/xfce/tumbler/-/blob/230e62f9bea2895509d4099a59806fa10c912ca7/plugins/xdg-cache/xdg-cache-thumbnail.c#L69) as a reference and testing with the built-in One Dark theme, I can attest that most of the syntax highlighting differences I saw were not intentional choices,...
> Is there an easy way to test #859 without rebuilding everything (which I'm afraid I can't do in a reasonable amount of time on my machine)? You can set...
It's supposed to fix the other built-in themes. I admit I only fixed One Dark and One Light earlier, but I'll make a note to revisit the others. > Also,...
> I realize that now only One Dark doesn't highlight function parameters (in function declaration and definition). Perhaps it would be a good thing to do so here too, if...
> This could be a bug: structure members are not highlighted in this definition (whatever the theme): Fixed in [this commit](https://github.com/pulsar-edit/pulsar/pull/859/commits/4d8a7219c37e9c856412a4bcbddd0ea5df3c1115). Thanks again for such great feedback!