Andrew Dupont

Results 560 comments of Andrew Dupont

OK, I'll take a look in a few hours with the latest CI build, using my own WordPress project as sample code.

I'm having no luck reproducing those symptoms on a CI build on my Mac, so I might try tomorrow on my seldom-used Windows machine.

> @savetheclocktower I installed on a fresh user profile with no packages installed except what comes with it, and `could not reproduce` the above behavior. > > I am concluding...

I'll comment out that query for now. I forgot I'd written that. User-defined constants honestly should go into `variable`, but with enough detail in the scope name that a theme...

My only theory on that — that an unusual parse state causes a failure — must be incorrect, or else there would be a message in the console. If you're...

A couple things: 1. I share the feeling expressed elsewhere that viewing a simple list of possible grammars to install might not give the user enough context. If I knew...

Typically the `injectionRegex` has been written to capture either uppercase or lowercase, but I don't have a problem with this. Seems like a more elegant way of handling it.

Doesn't `heredoc_body` take care of that?

So `heredoc_content` is a child of `heredoc_body`. We should choose to apply `string.unquoted.ruby` to one of them, not both, or else the scope will get repeated.

Hang on. This feedback still needs to be addressed: > So heredoc_content is a child of heredoc_body. We should choose to apply string.unquoted.ruby to one of them, not both, or...