save-cloud icon indicating copy to clipboard operation
save-cloud copied to clipboard

Use gzip compression for data sent from agent

Open petertrr opened this issue 4 years ago • 3 comments
trafficstars

What's done:

  • Support in agent
POST /heartbeat HTTP/1.1
Host: host.docker.internal:5100
Accept: application/json,application/json
Accept-Encoding: gzip
Accept-Charset: UTF-8
User-Agent: Ktor client
Content-Type: application/json
Content-Length: 103

Related to #298

petertrr avatar Oct 19 '21 09:10 petertrr

Codecov Report

Merging #329 (c50a3bc) into master (b189f49) will decrease coverage by 0.31%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #329      +/-   ##
============================================
- Coverage     75.78%   75.46%   -0.32%     
- Complexity      279      280       +1     
============================================
  Files            36       36              
  Lines          1276     1280       +4     
  Branches         96       98       +2     
============================================
- Hits            967      966       -1     
- Misses          208      211       +3     
- Partials        101      103       +2     
Impacted Files Coverage Δ
...ave/backend/controllers/TestExecutionController.kt 75.00% <100.00%> (+1.66%) :arrow_up:
.../cqfn/save/orchestrator/docker/ContainerManager.kt 87.32% <100.00%> (+0.18%) :arrow_up:
...n/save/orchestrator/controller/AgentsController.kt 71.11% <0.00%> (-8.38%) :arrow_down:
...rg/cqfn/save/orchestrator/service/DockerService.kt 69.56% <0.00%> (-0.86%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8226c23...c50a3bc. Read the comment docs.

codecov[bot] avatar Oct 19 '21 09:10 codecov[bot]

Looks like it is done, haha :)

orchestr7 avatar Oct 28 '21 15:10 orchestr7

Looks like it is done, haha :)

Not quite, it looks like it only adds support for decoding gzipped responses from the server. I was inspecting traffic with tcpdump, and request body still is displayed in plain text.

petertrr avatar Oct 28 '21 16:10 petertrr