save-cloud icon indicating copy to clipboard operation
save-cloud copied to clipboard

Massive renaming and removing of useless things

Open orchestr7 opened this issue 5 months ago • 4 comments

We should do a lot of renaming and removal of legacy shit.

  1. Rename all packages:
    • remove save and save-cloud prefixes completely for common modules. It can only be: save/cosv-common (ONLY for SAVE/COSV specific common, in terms of Kotlin MPP for Native + JVM + JS), common (MPP for JS + JVM which are used EVERYWHERE), common-frontend (JS only code shared between COSV, SAVE, etc.) and common-backend (JVM only logic shared between COSV, SAVE, if needed). save-common should NOT be used in ANY COSV module as well as cosv-common cannot be used in SAVE.
    • we should have cosv-frontend, save-frontend and save-backend, cosv-backend. For save-specific components it is ok to have save-orchestrator, save-agent, etc.;
    • rename packages:
      • COSV and common packages should NOT have save in it's name
      • save-cloud-common packages should be renamed to com.saveourtool.common
      • cosv-backend instead of com.saveourtool.save.cosv.repository should be named as com.saveourtool.cosv.repository
  2. Remove sandbox service (if someone wishes to have - can save in separate repository later);
  3. After the removal of sandbox service - merge orchestrator-common with save-orchestrator;

orchestr7 avatar Jan 13 '24 14:01 orchestr7

@nulls if you will have any other ideas - welcome to share

orchestr7 avatar Jan 13 '24 14:01 orchestr7

@nulls if you will have any other ideas - welcome to share

  1. Removing sandbox and merging save-orchestator-common with save-orchestrator can be done before renaming to reduce affected files
  2. Suggestion to create a tag before renaming (or a branch at least)
  3. We have save-cloud-charts, probably we need to split it too
  4. What's about api-gateway and authentication-service? They are required for COSV and SAVE. Do we need to rename packages there?

nulls avatar Jan 15 '24 08:01 nulls

  1. What's about api-gateway and authentication-service? They are required for COSV and SAVE. Do we need to rename packages there?

Yeah, need to rename their packages as well! com.saveourtool.api-gateway

orchestr7 avatar Jan 15 '24 13:01 orchestr7

We also need to rename the paths for entities in save-cloud-common

Cheshiriks avatar Jan 19 '24 10:01 Cheshiriks