Sasha Krassovsky

Speaking with Arseny, seems that we essentially need to make an XLogReader-compatible API for neon_walreader. Changes we need to make are: 1. Move walproposer state into shmem (specifically, information regarding...

Ok as far as I can tell, this must've been a different bug, because I"m failing to reproduce the conditions that @ars described. I wrote a test here: https://github.com/neondatabase/neon/pull/6872 The...

OK so update, test does seem to reproduce the issue, in that the logs print ``` PG:2024-02-27 20:56:03.023 GMT [1810266] STATEMENT: START_REPLICATION SLOT "sub1" LOGICAL 0/0 (proto_version '2', publication_names '"pub"')...

Reopening because to be clear: the test _does_ reproduce the issue

Closing as https://github.com/neondatabase/neon/pull/6872 is merged!

Yes I've since commented in the issue. Are the logs really an issue? It seems like this problem self-heals when the safekeeper comes back

So is this something worth fixing then, if it self-heals?

Need to approve these 3 PRs in postgres: - https://github.com/neondatabase/postgres/pull/406 - https://github.com/neondatabase/postgres/pull/405 - https://github.com/neondatabase/postgres/pull/404

> Also pgindent should be run Yes I ran pgindent locally but it reformatted a lot more stuff than just this PR, so I was going to make a followup...

Thank you very much for the reviews and the help!