gruyere icon indicating copy to clipboard operation
gruyere copied to clipboard

Windows support

Open VasilyKaiser opened this issue 1 year ago • 2 comments

Added support for Windows

Restrictions:

  • Powershell needs elevated privilege to run "Get-Process" with "-IncludeUserName" parameter.
    • If run withing non privileged session, usernames will not appear.

Problems:

  • Trying to kill ports using filter causes panic

    Caught panic:
    
    runtime error: invalid memory address or nil pointer dereference
    
    Restoring terminal...
    
    goroutine 1 [running]:
    runtime/debug.Stack()
            C:/Program Files/Go/src/runtime/debug/stack.go:24 +0x65
    runtime/debug.PrintStack()
            C:/Program Files/Go/src/runtime/debug/stack.go:16 +0x19
    github.com/charmbracelet/bubbletea.(*Program).Run.func1()
            C:/Users/vujov/go/pkg/mod/github.com/charmbracelet/[email protected]/tea.go:402 +0x95
    panic({0x1170100, 0x131f7f0})
            C:/Program Files/Go/src/runtime/panic.go:890 +0x263
    main.model.Update({{0x0, 0x1, 0x1, 0x1, 0x1, 0x1, {0x1197d1c, 0x7}, {0x1198537, 0x9}, ...}, ...}, ...)
            D:/GitHub/gruyere/main.go:110 +0x596
    github.com/charmbracelet/bubbletea.(*Program).eventLoop(0xc00018c000, {0x11dc478?, 0xc000071b00?}, 0x100458a?)
            C:/Users/vujov/go/pkg/mod/github.com/charmbracelet/[email protected]/tea.go:343 +0x60a
    github.com/charmbracelet/bubbletea.(*Program).Run(0xc00018c000)
            C:/Users/vujov/go/pkg/mod/github.com/charmbracelet/[email protected]/tea.go:465 +0x81d
    main.main()
            D:/GitHub/gruyere/main.go:178 +0x285
    
  • UI is messed up on Windows terminals

image

VasilyKaiser avatar Mar 04 '23 12:03 VasilyKaiser

I don't quite have the bandwidth to debug this right now. Would be happy to have someone take it to the finish line though.

savannahostrowski avatar May 04 '23 01:05 savannahostrowski

I'm going to convert this to a draft PR for now, until someone can help take it to the finish line for Windows or until I have a chance to take a look (hope that's okay!)

Related issue: #6

savannahostrowski avatar May 08 '23 04:05 savannahostrowski