atsresume icon indicating copy to clipboard operation
atsresume copied to clipboard

No opting out of the vercel app footnote link

Open dmgolembiowski opened this issue 1 year ago • 3 comments

Regarding this:

https://github.com/sauravhathi/atsresume/blob/919d4cbf37491bc42af2e1fe15d70494eea800e1/styles/globals.css#L137

I get wanting to advertise the fruits of your labor, but not allowing an obvious opt-out on something people submit to prospective employers is not a good-faith practice. Would you accept a PR that at least binds this to a boolean value determined by a checkbox on the page? It could default to true.

dmgolembiowski avatar Jul 04 '24 16:07 dmgolembiowski

Thank you for bringing this up! We appreciate your feedback and suggestion. We would be open to a PR that implements the following changes:

  1. Introduces a boolean value that controls the visibility of the footnote link.
  2. Adds a checkbox on the page to allow users to opt-out of displaying the footnote link.
  3. The checkbox should default to true to maintain the current behavior unless the user chooses to opt-out.

Please ensure that the changes are well-documented and tested. We look forward to reviewing your contribution!

sauravhathi avatar Jul 05 '24 16:07 sauravhathi

Hey just going to pop in here and add that I would have used this tool if it wasn't for this painful footnote

joeyjooste avatar May 03 '25 21:05 joeyjooste

Please make a option to include the footnode, i get that you want to get credit for your work, but having it just makes us fork the repo and change it ourselfs.

This app has huge potantial, so please!

Mrsluggan avatar May 29 '25 14:05 Mrsluggan