text-to-handwriting icon indicating copy to clipboard operation
text-to-handwriting copied to clipboard

Multiple pen colors in same page.

Open saurabhdaware opened this issue 4 years ago • 7 comments

A lot of people reached out to me on mails and Twitter to have this feature.

We can keep everything the way it is right now, but we can also allow users to select text and then change the value in drop-down to color only the selected part.

saurabhdaware avatar Jul 09 '20 18:07 saurabhdaware

To color the font or the background sir.Will like to work on this too.

Himanshunitrr avatar Jul 11 '20 04:07 Himanshunitrr

https://github.com/saurabhdaware/text-to-handwriting/issues/34#issuecomment-656999003

saurabhdaware avatar Jul 11 '20 06:07 saurabhdaware

we are a team of developers ,we would like to add this feature .Can we proceed?

Rishika1416 avatar Aug 23 '20 11:08 Rishika1416

Yes, sure! Just make sure they are in two different PRs that can be merged separately.

saurabhdaware avatar Aug 23 '20 12:08 saurabhdaware

yeah! I will make sure to make two different PRs . Will update you soon with any progress.

Rishika1416 avatar Aug 23 '20 13:08 Rishika1416

@saurabhdaware Could you please share the acceptance test criteria so that we can work with better efficiency and understand what do you expect after this issue is resolved.

Rishika1416 avatar Aug 24 '20 17:08 Rishika1416

We can keep everything the way it is right now, but we can also allow users to select text and then change the value in drop-down to color only the selected part.

This ^. So normally when I select ink color, it changes the color of the whole text.

After the PR,

  • if we select a particular text and then change the ink color in dropdown, it will only color the selected part and leave the other part as it is.
  • if we don't select any text, then it will change the color of the whole input (the way it works right now)

saurabhdaware avatar Aug 25 '20 05:08 saurabhdaware