react-evil-icons icon indicating copy to clipboard operation
react-evil-icons copied to clipboard

Published 20 hours ago • verified publisher icon saulhoward

Remove gulp from dependency

Open tnguyen14 opened this issue 7 years ago • 2 comments

Can gulp be moved to devDependency? Or spin the icon sprite inject gulp task into a separate repo? I'd like to use this, but don't want to pull gulp into my project.

tnguyen14 avatar Jun 30 '17 18:06 tnguyen14

Hi @tnguyen14 -- it's a good question, I agree that gulp shouldn't be a dependency.

Unfortunately, the current design uses gulp to build and inject the SVG 'sprites'. I would like to move to a different design (probably building the icons as separately importable React components). Hopefully I will get round to this soon, I just haven't been able to spare the time.

If you can suggest another way, please do send me a PR, and I'll definitely take a look.

saulhoward avatar Jul 04 '17 11:07 saulhoward

There are many ways the sprite can be included into the HTML, and gulp is just one. It is not very useful for projects that don't use gulp.

I think that instead of including gulp in this project, you should just add the task as part of the documentation as a suggestion for how the icon sprite could be injected.

tnguyen14 avatar Nov 30 '17 23:11 tnguyen14