saucerest-java icon indicating copy to clipboard operation
saucerest-java copied to clipboard

Remove silently failing REST calls

Open sceiler opened this issue 3 years ago • 0 comments

Description

Make all REST calls throw exceptions and remove all others who silently fail.

Motivation and Context

This removes really similar code reducing complexity and the need to always provide a silent/non-silent method for every API. In addition, it should be up to the user to decide actively what to do with exceptions thrown as a result of an API call failing. Silently failing can cause issues if the end user does not understand why a test asset was not downloaded. Having exceptions thrown at least promotes actively logging or handling the thrown exception giving more visibility in case of exceptions.

Further comments

In addition this will reduce complexity of the code base.

sceiler avatar Jul 16 '21 18:07 sceiler