sauce-java icon indicating copy to clipboard operation
sauce-java copied to clipboard

Published 20 hours ago • verified publisher icon saucelabs

Test update

Open joshgrantsauce opened this issue 5 years ago • 2 comments

Small updates for removing connections to Sauce Labs in existing unit tests for SOL-13. Also added some possible structure for acceptance tests that do in fact connect to Sauce Labs.

joshgrantsauce avatar Mar 19 '19 14:03 joshgrantsauce

Hey @joshgrantsauce I'm close to finishing this branch here: https://github.com/saucelabs/sauce-java/blob/js2/common/src/test/java/com.saucelabs.common/SauceHelperAcceptanceTest.java

And it pretty much overwrites all that you did in this PR. How do you want me to handle it. Our naming conventions are a little different, but I think we had the same idea. Do you want me to merge our branches and rename something? Or should I just PR my branch and we close this one?

nadvolod avatar Mar 22 '19 22:03 nadvolod

@nikolay-advolodkin you're farther along than I am, which is great! I'd say merge your changes and I'll either decline or update this PR as needed.

joshmgrant avatar Mar 25 '19 15:03 joshmgrant