react-native-tab-view icon indicating copy to clipboard operation
react-native-tab-view copied to clipboard

index in navigationState is ignored

Open jurisjansons opened this issue 3 years ago • 2 comments

Current behavior

index parameter in navigationState is ignored. You can swipe and change tab even when index is set to constant value.

Expected behavior

TabView is showing tab with given index

as from documentation:

onIndexChange (required) Callback which is called on tab change, receives the index of the new tab as argument. The navigation state needs to be updated when it's called, otherwise the change is dropped.

so, preventing index chande sould result in preventing tab switch

Reproduction

https://snack.expo.dev/CV5lqoORhN

Platform

  • [X] Android
  • [ ] iOS
  • [X] Web
  • [ ] Windows
  • [ ] MacOS

Environment

package version
react-native-tab-view 3.2.1
react-native-pager-view 5.4.24
react-native 0.69.5
expo 46.0.0
node 14.17.2
npm or yarn 8.11.0

jurisjansons avatar Oct 03 '22 11:10 jurisjansons

The versions mentioned in the issue for the following packages differ from the latest versions on npm:

  • react-native-pager-view (found: 5.4.24, latest: 6.0.0)
  • react-native (found: 0.69.5, latest: 0.70.1)
  • expo (found: 46.0.0, latest: 46.0.14)

Can you verify that the issue still exists after upgrading to the latest versions of these packages?

github-actions[bot] avatar Oct 03 '22 11:10 github-actions[bot]

Yeah, this is a bug. PRs welcome to fix it!

satya164 avatar Oct 03 '22 11:10 satya164