react-native-tab-view icon indicating copy to clipboard operation
react-native-tab-view copied to clipboard

Collapsible Header

Open KrisLau opened this issue 3 years ago • 4 comments

Description

I'm hoping to be able to do something like this: https://github.com/zyslife/react-native-head-tab-view or like what this guy describes: https://github.com/software-mansion/react-native-gesture-handler/issues/492#issuecomment-927353039. It's really hard to implement this manually since the nested scroll view in the tab view seems to conflict with PanGestureHandler

Alternatives

  • Using PanGestureHandler but it doesn't work because tab view already has a ScrollView and then the tab scenes I pass in also have a ScrollView
  • https://github.com/zyslife/react-native-head-tab-view but it hasn't been updated since June last year

Inspirations & examples

  • Tiktok Profile header: https://github.com/software-mansion/react-native-gesture-handler/issues/492#issuecomment-927353039
  • https://github.com/zyslife/react-native-head-tab-view

KrisLau avatar Aug 08 '22 20:08 KrisLau

Hey! Thanks for opening the issue. The issue doesn't seem to contain a link to a repro (a snack.expo.dev link or link to a GitHub repo under your username).

Can you provide a minimal repro which demonstrates the issue? A repro will help us debug the issue faster. Please try to keep the repro as small as possible and make sure that we can run it without additional setup.

github-actions[bot] avatar Aug 08 '22 20:08 github-actions[bot]

Couldn't find version numbers for the following packages in the issue:

  • react-native
  • react-native-tab-view
  • react-native-pager-view

Can you update the issue to include version numbers for those packages? The version numbers must match the format 1.2.3.

github-actions[bot] avatar Aug 08 '22 20:08 github-actions[bot]

https://github.com/satya164/react-native-tab-view/pull/1079#issuecomment-815261996

KrisLau avatar Aug 08 '22 20:08 KrisLau

Also if you need more maintainers @satya164, would you be open to maybe opening an issue to recruit and officially add maintainers? There are a couple issues here where people are offering to maintain the library plus once that issue is open I would also be able to submit this repo to https://github.com/pickhardt/maintainers-wanted

KrisLau avatar Aug 08 '22 20:08 KrisLau

@KrisLau I've added my comment on the PR (#1079). Hopefully we can merge this feature soon 👍🏻

okwasniewski avatar Aug 31 '22 14:08 okwasniewski

@okwasniewski Thank you!

KrisLau avatar Aug 31 '22 15:08 KrisLau

After consulting this with @satya164 we decided that we want to keep the library as small as possible (and easy to maintain) so I'm closing this issue.

okwasniewski avatar Sep 01 '22 06:09 okwasniewski