react-native-tab-view
react-native-tab-view copied to clipboard
Upgrade to last react-native-pager-view version
…Exception
Just to be up-to-date with the last react-native-pager-view
version.
Motivation
Related to this issue this last react-native-pager-view
version embed a bunch of critical fixs. I met randomly some of them on the app load when TabView is rendering for the first time.
Test plan
Nothing changes from the UI. Only one import from react-native-pager-view
is different inside PagerViewAdapter.tsx
.
Code formatting
Look around. Match the style of the rest of the codebase. Run yarn lint --fix
before committing.
Hey anthlasserre! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines.
Hi @anthlasserre this PR wont work, because the implementation is changed for new PagerView, it no longer accepts children, instead it takes views from renderItem
function. But still this change is important to be able to work with new Pager component.
@satya164 any plans for this fix? its breaking code.
Closing this, since it doesn't work. I will address upgrading react-native-pager-view
in a separate PR