react-native-tab-view icon indicating copy to clipboard operation
react-native-tab-view copied to clipboard

feat: add ability to type tab names with SceneRendererProps

Open pierpo opened this issue 4 years ago • 1 comments

Motivation

I'd like to add more strength to my typings while using the lib. I don't want to make mistakes while using tab names.

Test plan

This is a non breaking change. I can't think of any risk with this.

Here's when I add a type parameter (new behaviour):

image

Here's when I don't (same as previous behaviour):

image

Thank you!

pierpo avatar Aug 19 '21 21:08 pierpo

Hey pierpo! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines.

github-actions[bot] avatar Aug 19 '21 21:08 github-actions[bot]