react-native-tab-view icon indicating copy to clipboard operation
react-native-tab-view copied to clipboard

feat: add tabBarSpacing property

Open mlecoq opened this issue 4 years ago • 7 comments

Motivation

The goal is to support spacing between tabs ( see #1020 ) - It is roughly doable with some customizations (thanks to renderTabBarItem and renderIndicator methods) but it requires to modify internal methods (getTranslateX for example)

Test plan

I have added one example ( TabBarSpacingExample )

mlecoq avatar Mar 11 '21 10:03 mlecoq

@satya164 What do you think about this? It's very nice if we have this props.

blueberry6401 avatar Apr 08 '21 09:04 blueberry6401

Would definitely find this feature quite useful 👍

dparrelli avatar Jun 18 '21 05:06 dparrelli

Also add my vote on this 👍

hirbod avatar Sep 01 '21 01:09 hirbod

@mlecoq Do you have some time to rebase the PR? 🙏🏻

This way @satya164 can have a look and maybe include it in the next release!

Kerumen avatar Jan 19 '22 13:01 Kerumen

@Kerumen I'll make it soon (tomorrow)

mlecoq avatar Jan 19 '22 21:01 mlecoq

Hey mlecoq! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines.

github-actions[bot] avatar Jan 20 '22 08:01 github-actions[bot]

Would definitely find this feature quite useful +1

felipejh avatar Mar 24 '22 02:03 felipejh

Hey @mlecoq, thanks for your PR! Can you rebase this with the main branch? I will review this once you rebase it and test it again current pager-version.

okwasniewski avatar Aug 31 '22 17:08 okwasniewski

Hey @mlecoq, thanks for your PR! Can you rebase this with the main branch? I will review this once you rebase it and test it again current pager-version.

Done !

mlecoq avatar Aug 31 '22 19:08 mlecoq

Also just for naming, please remove the tabBar prefix and change the name to gap to match the CSS property which does the same thing

@okwasniewski Thanks for your feedback, I think I have taken into account all your remarks, please let me know if something is missing

mlecoq avatar Sep 01 '22 08:09 mlecoq