react-native-tab-view icon indicating copy to clipboard operation
react-native-tab-view copied to clipboard

[Suggestion] Passing ripple options for android

Open markoj3s opened this issue 3 years ago • 4 comments

Seems like there is a prop pressColor for android_ripple.color, however android_ripple.bordeless seems hard-coded. Would it be possible to pass this setting as a prop as well?

markoj3s avatar Mar 10 '21 16:03 markoj3s

Couldn't find version numbers for the following packages in the issue:

  • react-native
  • react-native-tab-view
  • react-native-pager-view

Can you update the issue to include version numbers for those packages? The version numbers must match the format 1.2.3.

github-actions[bot] avatar Mar 10 '21 16:03 github-actions[bot]

What's the effect that you want to achieve?

satya164 avatar Jul 29 '21 13:07 satya164

Hi @satya164 I just want to customize the ripple effect. Make it borderless or not borderless at will. Change color at will.

markoj3s avatar Aug 03 '21 09:08 markoj3s

android_ripple={{ borderless: true }} This is how it is set currently. Would be nice to pass android_ripple props, and otherwise, make it borderless if no props passed.

markoj3s avatar Aug 03 '21 09:08 markoj3s