Satyajit Sahoo

Results 419 comments of Satyajit Sahoo

> Currently the reader says “Show navigation menu” and the text is actually fixed The PR diff shows "Open navigation menu"

It still says "Open navigation menu". The PR also now includes many other changes such as removing `overlayAccessibilityLabel` and adding a new option. Please revert all changes other than `DrawerToggleButton`...

It still says "Open navigation menu" instead of "Show navigation menu" and there are other changes besides `DrawerToggleButton`.

Please stop pinging me multiple times. You can easily pass the prop yourself by rendering `DrawerToggleButton` if it's super critical to you. Either way, please don't ping maintainers in open...

@gianlucalippolis it's not necessary, i just did the change here https://github.com/react-navigation/react-navigation/commit/a98eb8ce659f75ca11892aa92f96bd5f755ced6e

This change should be done in screens package after this is merged https://github.com/software-mansion/react-native-screens/pull/2433

What do you think about adding `import.meta.resolve` in addition to `import.meta.url`? It's supported in both browsers and node, and would be a replacement for `require.resolve`.

I think this approach is problematic. Let's consider how it would work in practice: 1. Native code can only have a single version 2. JS code can have multiple versions...

> New command in the CLI to install packages - if there are any peer dependencies, it would ask if developer wants to install it. However I'm not fully convinced...