mapalign icon indicating copy to clipboard operation
mapalign copied to clipboard

Move transition matrix computation outside of main function

Open mfalkiewicz opened this issue 8 years ago • 3 comments

Refactoring the kernel normalization and transition matrix computation as independent function will allow for more code re-use.

mfalkiewicz avatar Jan 01 '18 21:01 mfalkiewicz

@mfalkiewicz - should #13 still be a PR?

satra avatar Jan 02 '18 17:01 satra

@satra: no, I merged them both together and deleted #13.

mfalkiewicz avatar Jan 02 '18 18:01 mfalkiewicz

also tests are not passing - since the markov computation has changed.

i would recommend creating a second markov option with your changes, unless you think the current implementation is an error. this will help keep the api consistent. and you can create a new set of embedding tests with the alternate calculation.

satra avatar Feb 01 '18 14:02 satra