Sergey Torgashov
Sergey Torgashov
I've just realized that I missed this suggestion from "CONTRIBUTING.md" > 2. Before starting to work, make sure there is a ticket in the issue or create one first. It...
```scala case class User( id: ID, name: String @GQLExtend extension1: UserExt @GQLExtend extension2: NodeExt ) ``` I thought about the nesting approach too, but my concern here is – if...
@joroKr21 , > Biggest offenders remaining Yet a substantial decrease in sizes is achieved, thank you! May I suggest the below representation of the size comparisons for nicer visualisation? |...
Hi @joroKr21 , thank you again for this incredible work! I'm going to put aside some time to wrap my head around this PR. Meanwhile, would you mind updating your...
@joroKr21 , thank you for keeping it up-to-date! I'm not sure if we should wait for the second approve, to be honest. From my perspective, the PR is ready to...
Looks like this one can be closed as resolved.
> The alternative is to return Unit for both branches. Just for reference, to keep stuff connected: #4626 I also think that instead of `ifTrueWhatever` and `ifFalseWhatever` we should use...
> There is no override of mapAccumulate for Seq, so should it be added with mapAccumulateFilter through StaticMethods.mapAccumulateFilterFromStrictFunctorFilter? I think it can be addressed in a separate follow-up PR, just...
> - Bikeshed question: why mapAccumulateFilter vs mapFilterAccumulate? I think I prefer the latter. > - I just added "Filter"-suffix after original method name from Traverse, same as in traverse...
> This is implementation of mapAccumulateFilter in terms of mapFilterAccumulate. f pattern matching should be changed inside out: Yes, thank you 😊 Anyway, `mapFilterAccumulate` looks like a special case for...