string_view

string_view copied to clipboard

substr() throws if pos == size

1

For example: ~~~ string_view x("abc"); string_view y = x.substr(3); ASSERT_TRUE(y == ""); ~~~ I would expect an empty string to be returned. Compare https://en.cppreference.com/w/cpp/string/basic_string_view/substr Note: See also https://github.com/bitwizeshift/string_view-standalone/issues/3, same issue...

AdmiralCurtiss

`error C2679: binary '==': no operator found which takes a right-hand operand of type 'const std::string_view' (or there is no acceptable conversion) ` * https://ci.appveyor.com/project/mgerhardy/engine/build/0.1-198#L3843 * https://github.com/mgerhardy/engine/blob/master/src/modules/core/tests/StringTest.cpp

mgerhardy