shadcn-admin icon indicating copy to clipboard operation
shadcn-admin copied to clipboard

Add toggle fullscreen functionality

Open muhammadcahya opened this issue 10 months ago • 2 comments

Description

Hi @satnaing, I apologize in advance, I didn't realize I had closed the pull request when I synced my repository LOL Here updated script to improve compatibility on any device, I don't use third party for this, so you can read the dom mechanism, and you can clearly review the code again. Thank you

Types of changes

Added toggle fullscreen functionality

image

  • [ ] Bug Fix (non-breaking change which fixes an issue)
  • [x] New Feature (non-breaking change which adds functionality)
  • [ ] Others (any other types not listed above)

Checklist

Related Issue

#75

Closes: #75

muhammadcahya avatar Feb 15 '25 12:02 muhammadcahya

Deploy Preview for shadcn-admin ready!

Name Link
Latest commit 6a5f45656d45fe8f765ab0385caf21f3eefcd325
Latest deploy log https://app.netlify.com/sites/shadcn-admin/deploys/67b086b04b56510008795f7b
Deploy Preview https://deploy-preview-97--shadcn-admin.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 15 '25 12:02 netlify[bot]

This feature is awesome, but there's an issue after toggling to full screen and navigating to another route, the toggle button remains fixed and doesn't allow exiting full screen until I press the Esc button. Screencast from 2025-03-07 12-49-34.webm

AliAkrem avatar Mar 07 '25 11:03 AliAkrem

Due to a few remaining bugs and inactivity, I'm closing this PR for now. Thanks for the PR tho! Appreciate it.

satnaing avatar Apr 16 '25 16:04 satnaing