SatisfactoryModManager icon indicating copy to clipboard operation
SatisfactoryModManager copied to clipboard

Translation issue: The icon for the buttons can get cut off if the string is too long

Open Czekoloczek opened this issue 1 year ago • 8 comments

The icon for the rename button gets cut off and I don't think that there's a shorter translation to Polish than this English version: obraz Polish version: obraz

This isn't a big problem since the button still works so it's only a visual problem.

Discord discussion on #translation-discussion

Czekoloczek avatar Sep 16 '24 18:09 Czekoloczek

More layout issues when translated (also in Polish): image

Creates overscroll and overflows sidebar image

EliWimmer avatar Sep 22 '24 18:09 EliWimmer

I can try to find other strings for the translations but they won't be the best pick for easy understanding ex. I can change "Zmień nazwę" to "Przemianuj" since this is also a word in Polish, but I've never heard it and no one I know ever used it

Czekoloczek avatar Sep 25 '24 20:09 Czekoloczek

So I've changed it because if I remember correctly it won't be fixed quickly (I should probably change it back after this issue is fixed) Nie znaleziono dostępnych aktualizacji modów/SMM > Brak dostępnych aktualizacji ~~Zmień nazwę > Przemianuj (it still says Zmień nazwę Profilu in the popup so the user should still understand what it does after they click it)~~ I've changed it back to Zmień nazwę because Przemianuj didn't help Wszystkie mody > Wszystkie Ostatnio zaktualizowane > Zaktualizowane

Czekoloczek avatar Sep 25 '24 20:09 Czekoloczek

still didn't work fully xD obraz ping me on discord after you fix it and notify me if you find anything else that's unreadable

Czekoloczek avatar Sep 25 '24 20:09 Czekoloczek

Since redesigning the UI to handle arbitrary translation lengths everywhere is quite hard, if even possible, the next best option I could find is to user marquee for the text on hover, added in 6f1404d27a4381acbc671c85d65255400ade9d67

https://github.com/user-attachments/assets/ccc1cbfa-1895-401e-a509-d876ad393c1d

mircearoata avatar Sep 29 '24 21:09 mircearoata

@mircearoata I found a small problem with that If you hover your mouse over the icon and not the text then the text won't move, are you able to change/fix that? obraz SatisfactoryModManager-dev_jtOvUtm4Uc

Czekoloczek avatar Oct 01 '24 13:10 Czekoloczek

Also that SatisfactoryModManager-dev_4oXW6mXtXL (It seems like it checks the string that's the longest and applies it to all strings for the list) And it doesn't work for the filtering of mods

Czekoloczek avatar Oct 01 '24 13:10 Czekoloczek

Fixed the second issue in dbefd0e6569eaa477f7e40ac1fec64fe98e392c2, the issue was that the amount to scroll was not updating when the content changed (followed by multiple variables not updating properly), so it just kept the animation of whichever text was first displayed

For the animate when hovering any part of the button, it's a bit more involved, so I didn't implement it yet

mircearoata avatar Oct 04 '24 17:10 mircearoata