sctransform icon indicating copy to clipboard operation
sctransform copied to clipboard

Please specify Matrix version with equal separation signs

Open tillea opened this issue 3 years ago • 2 comments

Hi, I'm aware that in R the signs '.' and '-' are sorting equally in version numbers. This is not true for Debian package versions und thus for the latest Debian package I needed the following patch:

-Imports: dplyr, magrittr, MASS, Matrix (>= 1.5.0), methods,
+Imports: dplyr, magrittr, MASS, Matrix (>= 1.5-0), methods,

for the version of Matrix. It would be extremely helpful if you would simply keep the same spelling for version numbers as the authors of a package have decided for. Kind regards, Andreas.

tillea avatar Sep 26 '22 13:09 tillea

Thanks for reporting this and for the patch. I will fix this in the next release.

saketkc avatar Sep 26 '22 23:09 saketkc

Am Mon, Sep 26, 2022 at 04:57:29PM -0700 schrieb Saket Choudhary:

Thanks for reporting this and for the patch. I will fix this in the next release. Thanks a lot for your cooperation, Andreas.

tillea avatar Oct 11 '22 09:10 tillea

Hi, unfortunately in version 0.4.0 the issue persists. I can patch it again inside the Debian package, but it would be great if you could commit a fix to Git to close this issue. Thanks a lot, Andreas.

tillea avatar Oct 17 '23 09:10 tillea

Apologies that I missed this in the latest release. For now I would recommend patching it at your end and will incorporate the fix in the next release.

saketkc avatar Oct 17 '23 12:10 saketkc

Am Tue, Oct 17, 2023 at 05:15:29AM -0700 schrieb Saket Choudhary:

Apologies that I missed this in the latest release. For now I would recommend patching it at your end and will incorporate the fix in the next release.

I've done so, yes. I'd simply recommend you push a fix to Git and close this issue to make sure it gets fixed next time. ;-) Kind regards, Andreas.

tillea avatar Oct 17 '23 12:10 tillea

Fixed in develop branch, thanks!

saketkc avatar Oct 17 '23 14:10 saketkc