phpbbgallery icon indicating copy to clipboard operation
phpbbgallery copied to clipboard

add htmlspecialchars to image_name in album.php

Open SiavaRu opened this issue 6 years ago • 7 comments

SiavaRu avatar Feb 06 '19 11:02 SiavaRu

Coverage Status

Coverage remained the same at 48.495% when pulling da9f21d114a0d8e7c364de2a41ad64724c8d409d on SiavaRu:patch-23 into 757d2cc6db4fa4a32faabc4dd6e39036d86bd70c on satanasov:master.

coveralls avatar Feb 06 '19 13:02 coveralls

@satanasov did you take a look at this? Dunno if this is still valid on the last version anymore. But I beleive it should still be valid.

Leinad4Mind avatar May 05 '19 16:05 Leinad4Mind

Hi there @SiavaRu I've been trying to see where this bugs come from but I couldnt find it. Could you please explain?

Leinad4Mind avatar Aug 15 '19 22:08 Leinad4Mind

Hi there @SiavaRu I've been trying to see where this bugs come from but I couldnt find it. Could you please explain?

Try use ' symbols in the title.

SiavaRu avatar Aug 16 '19 08:08 SiavaRu

Strange, I created at ACP an album with ' and & and even russian chars, nothing. Then I uploaded an image with those chars, the image was loaded and it appeared on the image name the same title with ' and & and russian chars. I sent sucessfully, all seems good. It seems to work on comments too.

What am I missing? @SiavaRu

Leinad4Mind avatar Aug 16 '19 10:08 Leinad4Mind

Today I was able to replicate the issue and fix it properly on #257 we can close this one @satanasov

Leinad4Mind avatar Jul 22 '21 12:07 Leinad4Mind

Just to remind you @satanasov, you can close this one. It was all already do solved by #257

Leinad4Mind avatar Jun 14 '23 12:06 Leinad4Mind