Sven Kanoldt

Regarding API design, I'm wondering if the design decision was on any purpose that `x11rb::connect(None)?;` returns `Result`? Specifically the opaque type `impl Connection` has [some downsides](https://stackoverflow.com/questions/52079983/what-is-the-advantage-of-publishing-a-concrete-type-in-a-crates-api-instead-of/52080290?noredirect=1#comment91111481_52080290). The biggest downside is...

The problem is not the Sized trait. So also a trait object (`Box`) is not that easy, for example: given a struct like this: ```rust struct X11Api { pub fn...

To be fair, I can get it working by not use the `x11rb::connect` and directly use for example the `RustConnection::connect`. But I fear that this is not the intended way...

So right now the issue is that there is a substitution happening and, since `NOKEY` is not defined, it will be treated as if it would be set to an...

@mgeisler do you need any help to finalize `mdbook-tera-backend` to have it releaes to crates.io?

I also ran into this. The change from having a `&str` to `String` on the arguments of the function that returns the `Result` did the trick for me.

Now the tests run all green and I have cleaned up the other test that used both `no_mangle` and `export_name` and simply removed the `no_mangle` in `tests/ui/asm/naked-functions.rs`. Please let me...

Thanks @Urgau for the guidance, I will refactor the code accordingly. The provided example seems pretty helpful to figure things out.

@Urgau I have refactored the code, but just to be sure I get things right, with this approach we won't have "named" lints that a user can allow or deny...

@rustbot review