node-sass icon indicating copy to clipboard operation
node-sass copied to clipboard
verified publisher icon sass

v5 Electron Support (5-8)

Open glenn2223 opened this issue 5 years ago • 3 comments

Adding support for electron v5-8. PR'ing to v5 due to node-gyp bump

glenn2223 avatar Mar 23 '20 00:03 glenn2223

Thank you @glenn2223 for your patience! I'll check if my build machinery can build node-sass for electron as well.

saper avatar Mar 23 '20 11:03 saper

Ref: Commit Fix: Extensions don't honour argument arch

Test 1: Step 5: Line 4 setting arch as ia32, Step 5: Line 447 save path uses x64 Test 2: Success

Thanks @saper

glenn2223 avatar Mar 23 '20 12:03 glenn2223

This seems to have a lot more random formatting churn and changes to the overall build setup than the last PR. What has changed that required this?

  • Formatting:
    Sorry I was working on another project at the same time so I just automatically hit my format shortcut. I can revert this if you wish?
  • Fix: (Fix: Extensions don't honour argument target-arch)
    Did you want this on another PR for this?
  • Electron targeting: I wasn't able to find a way to run electron commands (for each version) from the CI so I added a --electron-version argument. This added a function and expanded a couple of lines that I've added. This also has the added benefit of targeting an electron build without electron

glenn2223 avatar Apr 11 '20 06:04 glenn2223