node-sass icon indicating copy to clipboard operation
node-sass copied to clipboard

libsass 3.6

Open aldarund opened this issue 5 years ago • 14 comments

https://github.com/sass/libsass/releases/tag/3.6.0

aldarund avatar Jun 04 '19 00:06 aldarund

https://github.com/sass/libsass/releases/tag/3.6.1

I forked node-sass to integrate the latest libsass 3.6.1 commit #2b8a17a, mocha tests fail, but it does build successfully, and I'm able to use new libsass features like @content arguments. https://github.com/sass/node-sass/pull/2714

leefernandes avatar Jul 24 '19 20:07 leefernandes

Is adding support for 3.6 anywhere on the roadmap?

dylancopeland avatar Jul 25 '19 13:07 dylancopeland

It's a decent amount of work so it'll happen when I have a couple free days to build the binaries.

On Thu., 25 Jul. 2019, 11:38 pm Dylan Copeland, [email protected] wrote:

Is adding support for 3.6 anywhere on the roadmap?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sass/node-sass/issues/2685?email_source=notifications&email_token=AAENSWAVZZIS6JUVLOCIJLDQBGUFHA5CNFSM4HSWRSKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2ZP4TA#issuecomment-515046988, or mute the thread https://github.com/notifications/unsubscribe-auth/AAENSWBQE7HWWI2B3ZFTTALQBGUFHANCNFSM4HSWRSKA .

xzyfer avatar Jul 25 '19 13:07 xzyfer

libsass contains a HIGH severity vulnerability that is fixed in 3.6.0 https://nvd.nist.gov/vuln/detail/CVE-2018-19827 https://github.com/sass/libsass/commit/b21fb9f84096d9927780b86fa90629a096af358d

Can you provide a timeline for the update?

mbaluda avatar Aug 14 '19 09:08 mbaluda

libsass 3.6.0 also contains a fantastic bug fix sass/libsass#2849 that fixes some Windows specific compilation errors.

ZebraFlesh avatar Aug 29 '19 22:08 ZebraFlesh

And it implements passing arguments to content blocks, which is super useful. https://sass-lang.com/documentation/at-rules/mixin#passing-arguments-to-content-blocks

Lab43 avatar Sep 03 '19 18:09 Lab43

Is there any update on this?

AdamNatale avatar Sep 27 '19 20:09 AdamNatale

PR with upgrade is kinda waiting for several months, already ↪️ https://github.com/sass/node-sass/pull/2714

bricss avatar Oct 09 '19 07:10 bricss

PR with upgrade is kinda waiting for several months, already arrow_right_hook #2714

Does not seem that way to me, sorry!

saper avatar Oct 09 '19 12:10 saper

@xzyfer @nschonni What do you think about producing a 4.x release with libsass 3.6.x? ah, we can't due to https://github.com/sass/libsass/issues/2611

saper avatar Oct 17 '19 13:10 saper

Is this happing any time soon? I'm looking forward to mixin content block arguemnts. Thanks for making an maintaining this wonderful library <3

johnnyBira avatar Oct 28 '19 12:10 johnnyBira

image As per Azure Dev Ops report, libsass contains a HIGH severity vulnerability that is fixed in 3.6.0 Please can you provide timeline for the update?

karthikrajthandapani avatar Oct 30 '19 11:10 karthikrajthandapani

@karthikrajthandapani this is a volunteer-run project, so no timelines are provided. Sorry.

saper avatar Oct 30 '19 11:10 saper

This will land in 5.0. follow the open pr for updates.

On Wed, 30 Oct 2019, 10:48 pm Marcin Cieślak, [email protected] wrote:

@karthikrajthandapani https://github.com/karthikrajthandapani this is a volunteer-run project, so no timelines are provided. Sorry.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sass/node-sass/issues/2685?email_source=notifications&email_token=AAENSWGPJZ5UDHS44O7UNXLQRFYALA5CNFSM4HSWRSKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECT3YSI#issuecomment-547863625, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAENSWAVMSIRXWII6LOD6ADQRFYALANCNFSM4HSWRSKA .

xzyfer avatar Oct 30 '19 12:10 xzyfer