node-sass icon indicating copy to clipboard operation
node-sass copied to clipboard

Distribution support for linux s390x?

Open viane opened this issue 6 years ago • 9 comments

Hi, is it possible to contribute s390x binaries to the official repo without providing a s390x env? I have built v4.11.0 by using node v8-v11 under a real s390x node but unfortunately there is no way for me to get a node for public testing...

linux-s390x-57_binding.node.zip linux-s390x-59_binding.node.zip linux-s390x-64_binding.node.zip linux-s390x-67_binding.node.zip

And if no download available, it would take 3 minutes each time to build the fresh node-sass for our CI pipeline.

viane avatar May 01 '19 18:05 viane

Unless we can get a CI to consistently produce the binaries as part of our release process, we can't support the platform. This is similar to the requests for ARM support (which may change if the CI testing for that works out)

nschonni avatar May 30 '19 23:05 nschonni

@viane could this work under Hercules or something?

saper avatar Oct 17 '19 03:10 saper

@saper I read couple things about Hercules simulator running zlinux, and it sounds very achievable, i will play around the simulator and get back to you guys. Big thanks for brought this up!

viane avatar Oct 17 '19 05:10 viane

While here we don't we get node-sass working on MVS :)

saper avatar Oct 17 '19 12:10 saper

I think it will come with a price... and z/OS native support for nodejs is only up to v6, which is not a good option here I think. Which make me still want to try linux on z on the simulator first.

viane avatar Oct 17 '19 14:10 viane

Looks like Travis has added support now https://blog.travis-ci.com/2019-11-12-multi-cpu-architecture-ibm-power-ibm-z

nschonni avatar Nov 13 '19 02:11 nschonni

I tested build with travis, they seems like having issue with s390x arch builds. Will come back on this once they resolve the issue.

Also in few failed s390x builds, they are 2 common failing testcases:

  6084 passing (35s)
  753 pending
  2 failing
  1) binding missing error should be useful:
     Error: Node Sass does not yet support your current environment: Unsupported platform (unknown) 64-bit with Node.js 6.x
For more information on which environments are supported please see:
https://github.com/sass/node-sass/releases/tag/v4.13.0
      at module.exports (lib/binding.js:13:13)
      at test/binding.js:16:22
      at _tryBlock (assert.js:320:5)
      at _throws (assert.js:339:12)
      at Function.throws (assert.js:369:3)
      at Context.<anonymous> (test/binding.js:15:14)
  2) binding missing error should list currently installed bindings:
     Error: Node Sass does not yet support your current environment: Unsupported platform (unknown) 64-bit with Node.js 6.x
For more information on which environments are supported please see:
https://github.com/sass/node-sass/releases/tag/v4.13.0
      at module.exports (lib/binding.js:13:13)
      at test/binding.js:28:22
      at _tryBlock (assert.js:320:5)
      at _throws (assert.js:339:12)
      at Function.throws (assert.js:369:3)
      at Context.<anonymous> (test/binding.js:27:14)

viane avatar Nov 14 '19 00:11 viane

It would also need to be added to the known architectures like in https://github.com/sass/node-sass/pull/2783

nschonni avatar Nov 14 '19 00:11 nschonni

@nschonni I think we should fix those tests...

saper avatar Nov 16 '19 21:11 saper