node-sass icon indicating copy to clipboard operation
node-sass copied to clipboard

chore: Remove memory-tests

Open nschonni opened this issue 5 years ago • 1 comments

Just noticed these when I trying opening up the ESLint globs. These look specific to the work down in 4.7 memory performance stuff. Since we don't actually run this as part of any part of the build process I think they can be dropped.

nschonni avatar Jul 09 '18 06:07 nschonni

Let's keep these. I'm using them now for the N-API work to prevent regressions.

On Mon., 9 Jul. 2018, 4:37 pm Nick Schonning, [email protected] wrote:

Just noticed these when I trying opening up the ESLint globs. These look specific to the work down in 4.7 memory performance stuff. Since we don't actually run this as part of any part of the build process I think they can be dropped.

You can view, comment on, or merge this pull request online at:

https://github.com/sass/node-sass/pull/2442 Commit Summary

  • chore: Remove memory-tests

File Changes

Patch Links:

  • https://github.com/sass/node-sass/pull/2442.patch
  • https://github.com/sass/node-sass/pull/2442.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sass/node-sass/pull/2442, or mute the thread https://github.com/notifications/unsubscribe-auth/AAjZWFlNMLP8lg99nM80zRz-2UD6Cnyoks5uEvoOgaJpZM4VHJ38 .

xzyfer avatar Jul 09 '18 06:07 xzyfer