libsass icon indicating copy to clipboard operation
libsass copied to clipboard

Run C++ unit tests on AppVeyor

Open glebm opened this issue 5 years ago • 6 comments

Previously, these only ran on Travis.

glebm avatar Apr 13 '19 12:04 glebm

@glebm big thanks for all your work. I've given you commit access to unblock you.

xzyfer avatar Apr 13 '19 13:04 xzyfer

@xzyfer Thanks!

glebm avatar Apr 13 '19 13:04 glebm

@mgreter I don't have any msbuild / Windows experience. I've hand-coded these .vcxproj files based on MSDN tutorials, please take a look.

glebm avatar Apr 13 '19 13:04 glebm

@xzyfer I don't seem have commit access! No big deal though, as I'd like all my PRs reviewed anyway, but it'd be nice to be able to set labels on issues etc.

glebm avatar Apr 14 '19 18:04 glebm

Sorry I misclicked on mobile. You should have write access now.

Your changes are sensible so I'd prefer not to block your windows of productivity. Please to request reviews when you think it makes sense. I personally follow changes via Github emails so I'll pop up if I have string feelings about something.

Additionally this should give you the power to kill AppVeyor and Travis CI builds which can been a huge time saver.

xzyfer avatar Apr 15 '19 03:04 xzyfer

I know nothing about vs studio but agree with the intent of the change :)

xzyfer avatar Apr 15 '19 03:04 xzyfer