libsass-python icon indicating copy to clipboard operation
libsass-python copied to clipboard

Add wheels for musl linux

Open Bruceforce opened this issue 3 years ago • 8 comments

Hi, first let me thank you for your awesome work.

Is it possible to add musllinux wheel builds to pypi (PEP656)?

This would be great for all alpine users since it would simplify and speed up the installation of the libsass package.

Bruceforce avatar Jun 02 '22 08:06 Bruceforce

I guess here's where the wheels are built? https://github.com/sass/libsass-python/blob/main/bin/build-manylinux-wheels

I have no experience with this, but would it be easy to adapt and run a musl container to build musl wheels? There's just no standard OS as for https://github.com/pypa/manylinux as I could see?

toabi avatar Aug 11 '22 13:08 toabi

yeah I haven't seen any standardization on a base image -- we could make our own but ideally someone else would do that work lol

asottile avatar Aug 11 '22 14:08 asottile

Jeah. The cryptography people have their own apparently: https://github.com/pyca/cryptography/blob/main/.github/workflows/wheel-builder.yml#L34

toabi avatar Aug 11 '22 20:08 toabi

yeah they have some special requirements too like rust

asottile avatar Aug 11 '22 20:08 asottile

Just noticed, there are musllinux images there https://quay.io/organization/pypa - here: https://quay.io/repository/pypa/musllinux_1_1_x86_64?tab=tags

toabi avatar Aug 11 '22 20:08 toabi

@asottile I think it's quite sad to see #400 closed. It would be very useful in simplifying and speeding up docker builds.

So again, would you be open for a PR for building with https://github.com/pypa/cibuildwheel?

DeD1rk avatar Dec 23 '23 10:12 DeD1rk