go-openai icon indicating copy to clipboard operation
go-openai copied to clipboard

Allow custom Voice and Speech Models

Open adrianliechti opened this issue 11 months ago • 3 comments

this pull request removes the client-side logic to verify a valid speech and voice model. the motivation is to support custom models on openai compatible backends

thanks for considering

adrianliechti avatar Mar 22 '24 22:03 adrianliechti

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.88%. Comparing base (774fc9d) to head (6aeb72b). Report is 25 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #691      +/-   ##
==========================================
+ Coverage   98.46%   98.88%   +0.42%     
==========================================
  Files          24       26       +2     
  Lines        1364     1343      -21     
==========================================
- Hits         1343     1328      -15     
+ Misses         15        9       -6     
  Partials        6        6              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 22 '24 22:03 codecov[bot]

@adrianliechti thank you for the PR! I'm curious — are there any backends now that do support those?

sashabaranov avatar Apr 09 '24 08:04 sashabaranov

@sashabaranov thanks a ton for coming back on this! my own one adapts tools like mimic3, coqui.ai, whisper.cpp compatible ones into an openai-compatible api (also multiple ones). here a link: https://github.com/adrianliechti/llama. It is in use as part of a commercial platform at my employer. and since I was using your lovely SDK for both tests but also integration, I allowed me to create this PR.

I think it is in line with this project's recent changes on embedding/models - so I hope over time a broader audience benefits (or at least needs less urgent maintenance once openai releases new whisper or tts models)

adrianliechti avatar Apr 09 '24 11:04 adrianliechti

@sashabaranov Had you already found the time to consider this change?

adrianliechti avatar Jun 30 '24 14:06 adrianliechti

you made my day! cheers to you

adrianliechti avatar Jun 30 '24 15:06 adrianliechti