android-customtabs icon indicating copy to clipboard operation
android-customtabs copied to clipboard

Published 20 hours ago • verified publisher icon saschpe

Proguard is weak

Open androidmitry opened this issue 6 years ago • 3 comments

Hello everyone. Thanks for creating this awesome library. I faced some unusual problem. Proguard doesn't obfuscate code as I expect. I reviewed [https://github.com/saschpe/android-customtabs/blob/master/customtabs/proguard-rules.pro](Proguard rules) in the library and it looks like that this rule is too generic -keep public class * { public protected *; } This rule forces Proguard to keep all classes with public and protected fields. Thanks for help.

androidmitry avatar Oct 23 '18 11:10 androidmitry

Completely agree with it. Spent several hours until I figured this out. @saschpe can you, please, change this rule?

sergivonavi avatar Feb 12 '19 14:02 sergivonavi

Is this issue gonna be addressed? I lost an entire morning trying to figure out why my proguard wasn't obfuscating anything.

This library works very well, but it completely disables the proguard.

igorvilela28 avatar Mar 23 '19 17:03 igorvilela28

Version 2.0.3 should fix that. The library shipped the proguard-rules.pro file used to build it's release flavor. That wasn't actually necessary.

saschpe avatar May 16 '19 10:05 saschpe